Проверка плагина на ошибки

@eclarke1, @jjgrainger, and @felixarntz, could you please take a look at the instructions and let me know if anything needs to be updated or changed? Thank you!

@felixarntz I have added the test plugin in description. Please take a look. Thanks!

Hi @felixarntz @joemcgill @spacedmonkey @eclarke1 I have completed the QA testing for Plugin Checker and here are the findings:

One common issue that I faced for the plugins ( WooCommerce, Yoast SEO, etc..) that when trying to add or install their custom tables in the WordPress database during the runtime check, the tables were not created. This resulted in a «table not found» error, causing the runtime checks to be skipped. I will open an issue #234 to address this problem.

1. PHP 8.1.21 with WP 6.2.2 and 6.3 RC1

• Ran through the scenarios with the tester plugins.
• Ran through the plugin check with the WooCommerce, Elementor, Yoast SEO, Jetpack, Contact Form 7, Performance Lab, Ads.txt Manager plugins.
• Checked console for any errors. None found.
• Checked network for any errors. None found.
• Status: Passed ✅

1. PHP 8.0.29 with WP 6.2.2 and 6.3 RC1

• Ran through the scenarios with the tester plugins.
• Ran through the plugin check with the WooCommerce, Elementor, Yoast SEO, Jetpack, Contact Form 7, Performance Lab, Ads.txt Manager plugins.
• Checked console for any errors. None found.
• Checked network for any errors. None found.
• Status: Passed ✅

1. PHP 7.4 with WP 6.2.2 and 6.3 RC1

• Ran through the scenarios with the tester plugins.
• Ran through the plugin check with the WooCommerce, Elementor, Yoast SEO, Jetpack, Contact Form 7, Performance Lab, Ads.txt Manager plugins.
• Checked console for any errors. None found.
• Checked network for any errors. None found.
• Status: Passed ✅

1. PHP 7.0.33 with WP 6.2.2 and 6.3 RC1

• Ran through the scenarios with the tester plugins.
• Ran through the plugin check with the WooCommerce, Elementor, Yoast SEO, Jetpack, Contact Form 7, Performance Lab, Ads.txt Manager plugins.
• Checked console for any errors. None found.
• Checked network for any errors. None found.
• Status: Passed ✅

1. PHP 5.6.39 with WP 6.2.2

• WordPress 6.3 RC1

  • The WordPress 6.3 RC1 removed this php version support so we can’t test’s it.
  • Status: Not Tested ❌

• Admin screen check

  • Ran through the scenarios with the tester plugins.
  • Ran through the plugin check with the WooCommerce, Elementor, Yoast SEO, Jetpack, Contact Form 7, Performance Lab, Ads.txt Manager plugins.
  • Checked console for any errors. None found.
  • Checked network for any errors. None found.
  • Status: Passed ✅

• WP CLI check

  • When i ran CLI command with any arguments npm run wp-env run cli -- wp plugin check {plugin} --require=./wp-content/plugins/plugin-check/cli.php then it show If add parameter : Error: 'check' is not a registered subcommand of 'plugin'. See 'wp help plugin' for available subcommands. error message.

• When i ran CLI command without any arguments npm run wp-env run cli -- wp plugin check {plugin} it show one notice CLI: Strict Standards: Static function WordPress\Plugin_Check\Checker\Abstract_Check_Runner::is_plugin_check() should not be abstract in /var/www/html/wp-content/plugins/plugin-check/includes/Checker/Abstract_Check_Runner.php on line 102 and run the checks.

• Status: Partially Passed ❌

Considering that WordPress 6.3 raises the minimum required PHP version to 7.0, we can ignore the deeper PHP 5.6 CLI issues. If you want me to open issue for this then let me know.

I performed a static check using a plugin, and the output tool displayed several errors and notices for various plugins. Please find the summary below:

1. WooCommerce:

   • Files: 84
   • Errors Found: 32
   • Warnings Found: 122

2. Yoast SEO:

   • Files: 58
   • Errors Found: 84
   • Warnings Found: 110

3. Jetpack:

   • Files: 51
   • Errors Found: 25
   • Warnings Found: 105

4. Elementor:

   • Files: 84
   • Errors Found: 32
   • Warnings Found: 122

5. Contact Form 7:

   • Files: 91
   • Errors Found: 173
   • Warnings Found: 171

Already open WordPress/performance#787 issue for Performance Lab plugin.

Overall, the Plugin Checker has successfully passed testing for various PHP versions and WordPress versions.

@felixarntz I have thoroughly investigated the issue with the --require option in the CLI, and I can confirm the presence of the reported error. However, upon further testing, I noticed that when using a specific check option, such as --checks, the plugin functions work without any errors. This indicates that the issue might be specific to the --require option, and we need to delve deeper into the root cause.

Additionally, I conducted more tests by activating and deactivating the Plugin Checker plugin to gain further insights. Here are the findings from the testing:

PHP 5.6

CLI Command: npm run wp-env run cli -- wp plugin check test-plugin-check-errors/test-plugin-check-errors.php --require=./wp-content/plugins/plugin-check/cli.php

• Plugin Checker Active — ‘check’ is not a registered subcommand of ‘plugin’.
• Plugin Checker Deactivate — ‘check’ is not a registered subcommand of ‘plugin’.

CLI Command: npm run wp-env run cli -- wp plugin check test-plugin-check-errors/test-plugin-check-errors.php

• Plugin Checker Active — Checks working fine
• Plugin Checker Deactivate — ‘check’ is not a registered subcommand of ‘plugin’.

PHP 8.0.29

CLI Command: npm run wp-env run cli -- wp plugin check test-plugin-check-errors/test-plugin-check-errors.php --require=./wp-content/plugins/plugin-check/cli.php

• Plugin Checker Active — Checks working fine
• Plugin Checker Deactivate — Error:

[24-Jul-2023 06:28:34 UTC] PHP Fatal error: Uncaught Error: Undefined constant "WordPress\Plugin_Check\Checker\Checks\WP_PLUGIN_CHECK_PLUGIN_DIR_PATH" in /var/www/html/wp-content/plugins/plugin-check/includes/Checker/Checks/Abstract_PHP_CodeSniffer_Check.php:63
Stack trace:
#0 /var/www/html/wp-content/plugins/plugin-check/includes/Checker/Checks.php(80): WordPress\Plugin_Check\Checker\Checks\Abstract_PHP_CodeSniffer_Check->run(Object(WordPress\Plugin_Check\Checker\Check_Result))
#1 /var/www/html/wp-content/plugins/plugin-check/includes/Checker/Checks.php(45): WordPress\Plugin_Check\Checker\Checks->run_check_with_result(Object(WordPress\Plugin_Check\Checker\Checks\I18n_Usage_Check), Object(WordPress\Plugin_Check\Checker\Check_Result))
#2 [internal function]: WordPress\Plugin_Check\Checker\Checks->WordPress\Plugin_Check\Checker\{closure}(Object(WordPress\Plugin_Check\Checker\Checks\I18n_Usage_Check), 'i18n_usage')
#3 /var/www/html/wp-content/plugins/plugin-check/includes/Checker/Checks.php(46): array_walk(Array, Object(Closure))
#4 /var/www/html/wp-content/plugins/plugin-check/includes/Checker/Abstract_Check_Runner.php(278): WordPress\Plugin_Check\Checker\Checks->run_checks(Object(WordPress\Plugin_Check\Checker\Check_Context), Array)
#5 /var/www/html/wp-content/plugins/plugin-check/includes/CLI/Plugin_Check_Command.php(154): WordPress\Plugin_Check\Checker\Abstract_Check_Runner->run()
#6 [internal function]: WordPress\Plugin_Check\CLI\Plugin_Check_Command->check(Array, Array)
#7 phar:///usr/local/bin/wp/vendor/wp-cli/wp-cli/php/WP_CLI/Dispatcher/CommandFactory.php(100): call_user_func(Array, Array, Array)
#8 [internal function]: WP_CLI\Dispatcher\CommandFactory::WP_CLI\Dispatcher\{closure}(Array, Array)
#9 phar:///usr/local/bin/wp/vendor/wp-cli/wp-cli/php/WP_CLI/Dispatcher/Subcommand.php(491): call_user_func(Object(Closure), Array, Array)
#10 phar:///usr/local/bin/wp/vendor/wp-cli/wp-cli/php/WP_CLI/Runner.php(431): WP_CLI\Dispatcher\Subcommand->invoke(Array, Array, Array)
#11 phar:///usr/local/bin/wp/vendor/wp-cli/wp-cli/php/WP_CLI/Runner.php(454): WP_CLI\Runner->run_command(Array, Array)
#12 phar:///usr/local/bin/wp/vendor/wp-cli/wp-cli/php/WP_CLI/Runner.php(1269): WP_CLI\Runner->run_command_and_exit()
#13 phar:///usr/local/bin/wp/vendor/wp-cli/wp-cli/php/WP_CLI/Bootstrap/LaunchRunner.php(28): WP_CLI\Runner->start()
#14 phar:///usr/local/bin/wp/vendor/wp-cli/wp-cli/php/bootstrap.php(83): WP_CLI\Bootstrap\LaunchRunner->process(Object(WP_CLI\Bootstrap\BootstrapState))
#15 phar:///usr/local/bin/wp/vendor/wp-cli/wp-cli/php/wp-cli.php(32): WP_CLI\bootstrap()
#16 phar:///usr/local/bin/wp/php/boot-phar.php(20): include('phar:///usr/loc...')
#17 /usr/local/bin/wp(4): include('phar:///usr/loc...')
#18 {main}
 thrown in /var/www/html/wp-content/plugins/plugin-check/includes/Checker/Checks/Abstract_PHP_CodeSniffer_Check.php on line 63
Fatal error: Uncaught Error: Undefined constant "WordPress\Plugin_Check\Checker\Checks\WP_PLUGIN_CHECK_PLUGIN_DIR_PATH" in /var/www/html/wp-content/plugins/plugin-check/includes/Checker/Checks/Abstract_PHP_CodeSniffer_Check.php:63
Stack trace:
#0 /var/www/html/wp-content/plugins/plugin-check/includes/Checker/Checks.php(80): WordPress\Plugin_Check\Checker\Checks\Abstract_PHP_CodeSniffer_Check->run(Object(WordPress\Plugin_Check\Checker\Check_Result))
#1 /var/www/html/wp-content/plugins/plugin-check/includes/Checker/Checks.php(45): WordPress\Plugin_Check\Checker\Checks->run_check_with_result(Object(WordPress\Plugin_Check\Checker\Checks\I18n_Usage_Check), Object(WordPress\Plugin_Check\Checker\Check_Result))
#2 [internal function]: WordPress\Plugin_Check\Checker\Checks->WordPress\Plugin_Check\Checker\{closure}(Object(WordPress\Plugin_Check\Checker\Checks\I18n_Usage_Check), 'i18n_usage')
#3 /var/www/html/wp-content/plugins/plugin-check/includes/Checker/Checks.php(46): array_walk(Array, Object(Closure))
#4 /var/www/html/wp-content/plugins/plugin-check/includes/Checker/Abstract_Check_Runner.php(278): WordPress\Plugin_Check\Checker\Checks->run_checks(Object(WordPress\Plugin_Check\Checker\Check_Context), Array)
#5 /var/www/html/wp-content/plugins/plugin-check/includes/CLI/Plugin_Check_Command.php(154): WordPress\Plugin_Check\Checker\Abstract_Check_Runner->run()
#6 [internal function]: WordPress\Plugin_Check\CLI\Plugin_Check_Command->check(Array, Array)
#7 phar:///usr/local/bin/wp/vendor/wp-cli/wp-cli/php/WP_CLI/Dispatcher/CommandFactory.php(100): call_user_func(Array, Array, Array)
#8 [internal function]: WP_CLI\Dispatcher\CommandFactory::WP_CLI\Dispatcher\{closure}(Array, Array)
#9 phar:///usr/local/bin/wp/vendor/wp-cli/wp-cli/php/WP_CLI/Dispatcher/Subcommand.php(491): call_user_func(Object(Closure), Array, Array)
#10 phar:///usr/local/bin/wp/vendor/wp-cli/wp-cli/php/WP_CLI/Runner.php(431): WP_CLI\Dispatcher\Subcommand->invoke(Array, Array, Array)
#11 phar:///usr/local/bin/wp/vendor/wp-cli/wp-cli/php/WP_CLI/Runner.php(454): WP_CLI\Runner->run_command(Array, Array)
#12 phar:///usr/local/bin/wp/vendor/wp-cli/wp-cli/php/WP_CLI/Runner.php(1269): WP_CLI\Runner->run_command_and_exit()
#13 phar:///usr/local/bin/wp/vendor/wp-cli/wp-cli/php/WP_CLI/Bootstrap/LaunchRunner.php(28): WP_CLI\Runner->start()
#14 phar:///usr/local/bin/wp/vendor/wp-cli/wp-cli/php/bootstrap.php(83): WP_CLI\Bootstrap\LaunchRunner->process(Object(WP_CLI\Bootstrap\BootstrapState))
#15 phar:///usr/local/bin/wp/vendor/wp-cli/wp-cli/php/wp-cli.php(32): WP_CLI\bootstrap()
#16 phar:///usr/local/bin/wp/php/boot-phar.php(20): include('phar:///usr/loc...')
#17 /usr/local/bin/wp(4): include('phar:///usr/loc...')
#18 {main}
 thrown in /var/www/html/wp-content/plugins/plugin-check/includes/Checker/Checks/Abstract_PHP_CodeSniffer_Check.php on line 63
Error: There has been a critical error on this website.Learn more about troubleshooting WordPress. There has been a critical error on this website.

CLI Command: npm run wp-env run cli -- wp plugin check test-plugin-check-errors/test-plugin-check-errors.php

• Plugin Checker Active — Checks working fine
• Plugin Checker Deactivate — ‘check’ is not a registered subcommand of ‘plugin’.

We should register the CLI command only when the Plugin Checker plugin is activated; otherwise, it will display the error message.

Thanks @felixarntz for the feedback.

We should register the CLI command only when the Plugin Checker plugin is activated; otherwise, it will display the error message.

That makes sense. I think we should check this in our cli.php file and throw an exception if the plugin is not active (CLI users should not require this file if the plugin is not active).

I have open PR #236 that address this issue. Please take a look. Thanks!

Another thing: You mention for PHP 5.6 the following:

Plugin Checker Active — ‘check’ is not a registered subcommand of ‘plugin’.

Any idea why that happens? It’s odd to me that the plugin command is not found even though the plugin is active. And that only happens on 5.6 but not 8.0? 🤔

it seems that the issue is related to the way subcommands are registered and loaded in PHP 5.6. I have identified that when using npm run wp-env run cli command with the specific —require option to load the subcommand file explicitly, it works fine and runs the checks. This indicates that there might be an autoloading or registration issue in the PHP 5.6 environment.

In PHP 5.6, the autoloading might behave differently, and it might not load the subcommand file properly when using the WP_CLI::add_command() function. Therefore, manually requiring the subcommand file ensures that the necessary code is loaded, and the subcommand becomes available for use.

The correct command to run the checks in the PHP 5.6 environment, as per your findings, would be:

npm run wp-env run cli -- wp plugin check test-plugin-check-errors/test-plugin-check-errors.php --require=./wp-content/plugins/plugin-check/includes/CLI/Plugin_Check_Command.php

Please review the following and provide your feedback so that I can proceed with closing this issue. We have already opened follow-up issues and PRs. Thank you. cc. @joemcgill